Port build system to meson #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that we can finally build a shared library correctly without to much hassle and will be able to use pkgsStatic as well (provided we fix the dependencies upstream). redo is nice, but, while its dependency tracking is better, you end up scripting a lot in a lot of different places.
We'll be able to use this for the Haskell bindings and will ease packaging in general.
buchstabensuppe.h already included bitmap.h, flipdot.h was the only independent one. Since it is relatively simple and contains generally useful view manipulation routines, we can merge it into the main one as well.
sternenseemann
force-pushed
the
python-bindings
branch
from
3035bf7 to
0d5a14d
Compare
eli-schwartz
suggested changes
Jan 21, 2025
| .dep** | ||
| .target.* | ||
| .lock.* | ||
| /build |
There was a problem hiding this comment.
Good news, even this single line is unnecessary: https://mesonbuild.com/FAQ.html#how-do-i-ignore-the-build-directory-in-my-vcs
:)
| harfbuzz = dependency('harfbuzz') | ||
| # TODO: no pkg-config upstream, maybe ask for it? | ||
| schrift = cc.find_library('schrift') | ||
| math = cc.find_library('m') |
There was a problem hiding this comment.
On some platforms, the math library is built into libc. We suggest you use required: false here:
https://mesonbuild.com/howtox.html#add-math-library-lm-portably
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.